Skip to content

feat: implement gRPC connection with keepalive and retry interceptor#138

Merged
mateeullahmalik merged 1 commit intomasterfrom
lumerRetryLogic
Aug 27, 2025
Merged

feat: implement gRPC connection with keepalive and retry interceptor#138
mateeullahmalik merged 1 commit intomasterfrom
lumerRetryLogic

Conversation

@mateeullahmalik
Copy link
Copy Markdown
Collaborator

@mateeullahmalik mateeullahmalik commented Aug 25, 2025

Fixes permanent lumera connection failures on transient network errors by adding automatic retry with exponential backoff and keepalive configuration.

@a-ok123 a-ok123 requested review from a-ok123 and Copilot August 26, 2025 17:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements gRPC connection improvements to handle transient network errors by adding automatic retry with exponential backoff and keepalive configuration to prevent permanent connection failures.

  • Replaces direct gRPC dialing with a more robust connection mechanism featuring keepalive parameters
  • Adds a retry interceptor with exponential backoff (2s → 4s → 8s → 16s → 30s capped) for failed calls
  • Introduces comprehensive test coverage for connection normalization, retry logic, and edge cases

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pkg/lumera/connection.go Implements gRPC connection with keepalive parameters and retry interceptor with exponential backoff
pkg/lumera/connection_test.go Adds comprehensive test coverage for address normalization, connection methods, and retry behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mateeullahmalik mateeullahmalik merged commit e537032 into master Aug 27, 2025
7 checks passed
@mateeullahmalik mateeullahmalik deleted the lumerRetryLogic branch September 5, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants