Skip to content

Enabled Ledger support#109

Open
a-ok123 wants to merge 2 commits intomasterfrom
feature/ledger
Open

Enabled Ledger support#109
a-ok123 wants to merge 2 commits intomasterfrom
feature/ledger

Conversation

@a-ok123
Copy link
Contributor

@a-ok123 a-ok123 commented Mar 21, 2026

No description provided.

@roomote-v0
Copy link

roomote-v0 bot commented Mar 21, 2026

Rooviewer Clock   See task

No issues found. The latest commit generalizes hardcoded build/ paths to use ${BUILD_DIR}, separates debug output into ${BUILD_DIR}/debug/, and makes BUILD_TAGS overridable. All changes are backward-compatible with the default BUILD_DIR=build value and consistent with Makefile.devnet references.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote-v0[bot]
roomote-v0 bot previously approved these changes Mar 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Ledger support by building the chain with the ledger build tag and updates protobuf dependency locks accordingly.

Changes:

  • Add Makefile support for passing --build.tags "ledger" during ignite chain build.
  • Update GitHub Actions workflows (system tests + release) to build with the ledger tag.
  • Update buf.lock dependency commits/digests (notably cosmos-sdk and wellknowntypes).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.

File Description
buf.lock Updates locked buf dependencies to newer commits/digests.
Makefile Introduces build-tag handling and applies it to build/release commands.
.github/workflows/systemtests.yaml Builds the chain with --build.tags "ledger" in CI system tests.
.github/workflows/release.yml Builds release artifacts with --build.tags "ledger".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants