feat(server): GgufMetadata reader + SHA-256 sidecar for /props schema-4#344
Open
easel wants to merge 1 commit into
Open
feat(server): GgufMetadata reader + SHA-256 sidecar for /props schema-4#344easel wants to merge 1 commit into
easel wants to merge 1 commit into
Conversation
5 tasks
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
## What Adds a richer GGUF identity reader on top of Howard Su's existing `gguf_inspect` (PR Luce-Org#305): - `GgufMetadata` struct — captures `general.*` + `<arch>.*` header fields (architecture, name, file_type, quantization_version, block_count, embedding_length, context_length, vocab_size) with -1 / "" sentinels distinguishing "not in GGUF" from legitimate zero. - `read_gguf_metadata(path, compute_sha256)` — best-effort header read; optional SHA-256 of the whole file. - Self-contained SHA-256 mini-impl (RFC 6234) — no OpenSSL dependency added for one hash. - `<path>.sha256` sidecar caching — first server start hashes the file (~30s for a 17 GB GGUF on NVMe), subsequent starts read the sidecar. Sidecar I/O failures are non-fatal. - `llama_ftype_name` decode — maps `general.file_type` ints to human-readable names ("Q4_K_M", "IQ4_XS", etc.) for /props. ## Why `/props` schema-4 wants a single authoritative "exactly what binary + GGUF + quant + sha256 is loaded" payload so benchmarking and provenance tooling can pin model identity across runs without re-parsing GGUF headers in every consumer. The sidecar makes the SHA-256 free after the first boot, which is what makes it usable as a default-on identity field. ## Dependencies None. This is purely additive on top of `gguf_inspect.{cpp,h}` as merged in PR Luce-Org#305 — zero deletions, 333 insertions total. No other server files or build rules change in this PR; consumers will be wired up separately. ## Scope note This PR is the extracted-and-cleaned remnant of the previously closed PR Luce-Org#336 after a provenance audit; everything else from that branch (c2_gate, qwen3 drafter changes, structural-defense loaders, and the inadvertent reverts of Luce-Org#273/Luce-Org#295/Luce-Org#297) is either landing through its canonical PR (Luce-Org#274) or being dropped entirely.
532f678 to
f7d8278
Compare
easel
pushed a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 5, 2026
easel
pushed a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 5, 2026
easel
pushed a commit
to easel/lucebox-hub
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a richer GGUF identity reader on top of Howard Su's existing
gguf_inspect(PR #305):GgufMetadatastruct — capturesgeneral.*+<arch>.*header fields (architecture, name, file_type, quantization_version, block_count, embedding_length, context_length, vocab_size) with-1/""sentinels distinguishing "not in GGUF" from legitimate zero.read_gguf_metadata(path, compute_sha256)— best-effort header read; optional SHA-256 of the whole file.<path>.sha256sidecar caching — first server start hashes the file (~30s for a 17 GB GGUF on NVMe), subsequent starts read the sidecar. Sidecar I/O failures are non-fatal.llama_ftype_namedecode — mapsgeneral.file_typeints to human-readable names (Q4_K_M,IQ4_XS, etc.) for/props.Why
/propsschema-4 wants a single authoritative "exactly what binary + GGUF + quant + sha256 is loaded" payload so benchmarking and provenance tooling can pin model identity across runs without re-parsing GGUF headers in every consumer. The sidecar makes SHA-256 free after the first boot, which is what makes it usable as a default-on identity field.Dependencies
None. Purely additive on top of
gguf_inspect.{cpp,h}as merged in PR #305 — zero deletions, 333 insertions total. No other server files or build rules change in this PR;/propsconsumers will be wired up in a follow-up.Diff stat
Scope / provenance note
This PR is the extracted-and-cleaned remnant of the previously closed PR #336 after a provenance audit. Everything else from that branch (
c2_gate, qwen3 drafter changes, structural-defense loaders, and the inadvertent reverts of #273 / #295 / #297) is either landing through its canonical PR (#274) or being dropped entirely. Only this 333-line additive layer on top of Howard's priorgguf_inspectis Erik's own work and survives the audit.Test plan
dflash-servercompiles unchanged (no other files touched, so this is mostly a "does it still link" check).read_gguf_metadata("…/qwen3-coder-30b-iq4_xs.gguf", true)round-trip on a known model: confirmfile_type_name == "IQ4_XS",block_count,context_lengthmatchllama-gguf-dump.*.sha256, call once → sidecar appears with 64-hex-char SHA-256 + newline; call again → no re-hash (instrument with a print or strace).general.quantization_version: field stays at-1,ok == true.