fix(server): support sampled requests in target layer split#295
Open
weicj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 11 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
742b86c to
a9aedf7
Compare
easel
pushed a commit
to easel/lucebox-hub
that referenced
this pull request
May 28, 2026
# Conflicts: # server/src/gemma4/gemma4_layer_split_adapter.cpp # server/src/qwen35/qwen35_layer_split_adapter.cpp
easel
pushed a commit
to easel/lucebox-hub
that referenced
this pull request
May 28, 2026
Remove the repeated drafter/anchor test target block so CMake can configure the integration stack after merging upstream and PR Luce-Org#295.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From the user side, target layer split currently works for greedy requests but rejects normal sampled OpenAI-compatible requests with
sampling_unsupported. In practice this means requests usingtemperature > 0such astemperature=0.7, or requests using repetition / frequency / presence penalties, fail even though the same model can sample correctly on the single-card backend.This PR fixes that gap for target layer split. Adapters that can return final-token logits may opt into the existing CPU sampler path, so split and non-split generation follow the same sampling rules. Adapters that have not implemented logits output still fail explicitly instead of silently falling back to inconsistent behavior.
Changes
LayerSplitAdapter::supports_cpu_sampling()capability gate.sampling_unsupportedprotection for adapters that do not opt in.sample_logits()path during AR decode whentemperature > 0, repetition penalty, frequency penalty, or presence penalty is active.Notes
dflash_common,test_server_unit, anddflash_serverbuild passed;test_server_unitpassed with 1606 assertions and 0 failures. HIP gfx906dflash_serverbuild passed, and a dual Pro VII Gemma4 E4B Q4 layer-split smoke returned an OpenAI-compatible completion withtemperature=0.7.