Skip to content

feat(server): add Gemma4 draft residency support#291

Open
weicj wants to merge 3 commits into
Luce-Org:mainfrom
weicj:feat-gemma4-draft-residency-followup
Open

feat(server): add Gemma4 draft residency support#291
weicj wants to merge 3 commits into
Luce-Org:mainfrom
weicj:feat-gemma4-draft-residency-followup

Conversation

@weicj
Copy link
Copy Markdown
Collaborator

@weicj weicj commented May 28, 2026

Summary

This follow-up PR extends the shared draft residency policy from #290 with Gemma4 draft-only park/unpark support.

#290 keeps Gemma4 out of scope to keep the policy change small. Gemma4 needs a slightly larger internal reshaping because its draft-load path currently lives inside Gemma4Backend::init(), so draft-only residency requires extracting that path into reusable load/free helpers.

Changes

  • Extract Gemma4 decode-draft loading from Gemma4Backend::init() into a reusable helper.
  • Add a matching helper to free only the Gemma4 decode draft state.
  • Teach Gemma4Backend::park("draft") and Gemma4Backend::unpark("draft") to release/reload the draft without unloading the target model.
  • Keep target park/unpark behavior unchanged.

@weicj weicj force-pushed the feat-gemma4-draft-residency-followup branch from 8e54210 to 25f0efa Compare May 31, 2026 11:44
@weicj weicj marked this pull request as ready for review May 31, 2026 17:24
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 10 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread server/src/gemma4/gemma4_backend.cpp
easel pushed a commit to easel/lucebox-hub that referenced this pull request May 31, 2026
Merge PR Luce-Org#291's draft residency policy and Gemma4 draft lifecycle support into the current auto-integration stack while preserving passthrough PFlash options, transitive compression overrides, status/cancellation behavior, and existing server unit coverage. PR Luce-Org#290 is represented by this superset head.
easel pushed a commit to easel/lucebox-hub that referenced this pull request May 31, 2026
Record the Luce-Org#291/Luce-Org#290 draft-residency integration, newly non-draft Luce-Org#321/Luce-Org#325 classification, validation, and retained worktree/transcript paths for the May 31 13:30 UTC run.
easel pushed a commit to easel/lucebox-hub that referenced this pull request May 31, 2026
Record the post-push Luce-Org#324 head advance and conflict resolution after integrating Luce-Org#291/Luce-Org#290.
easel pushed a commit to easel/lucebox-hub that referenced this pull request May 31, 2026
Integrate current Luce-Org/lucebox-hub PR Luce-Org#291 head into the auto-integration patch stack.
easel pushed a commit to easel/lucebox-hub that referenced this pull request May 31, 2026
Record the exact Luce-Org#290/Luce-Org#291 merges, current Luce-Org#321/Luce-Org#325 classification, retained worktrees, and validation for the 2026-05-31 13:57 integration run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant