Remove old Python Receiver setup unit test#91
Merged
DanGould merged 1 commit intoLtbLightning:mainfrom May 9, 2025
Merged
Conversation
This test was written against an old version rust-payjoin and is not worth restoring. The same test case is now being covered by the [Python integration test](LtbLightning#85).
benalleng
approved these changes
May 9, 2025
DanGould
approved these changes
May 9, 2025
Contributor
|
How was Check this out: The test failed but CI still passed https://github.com/LtbLightning/payjoin-ffi/actions/runs/14843323481/job/41671223662 I believe because the (now removed) test didn't call self.fail except Exception as e:
return f"PayjoinError: {e}"How do we prevent repeating this problem? |
Contributor
Author
|
@DanGould yes exactly the test just try catched the missing headers runtime error.
Proper codereview. This test looks like it was pushed in a WIP status and was never reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was written against an old version rust-payjoin and is not worth restoring. The same test case is now being covered by the Python integration test.