Merged
Conversation
f4752d9 to
0a9f79e
Compare
GitHub runner support for ubuntu-20.04 has expired. python 3.8 is no longer pre-installed on ubuntu-24.04 but python 3.13 is.
0a9f79e to
13c644b
Compare
The other python versions run faster on linux. I am comfortable testing python versions under the linux matrix only, and just making sure the python 3.12 builds on mac.
Contributor
Author
|
Curious if there is a faster MacOS runner available, but I do think this improvement is still significant to our dev flow. |
spacebear21
approved these changes
Apr 17, 2025
benalleng
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure became apparent in #79. And We're slowing down our CI by testing every single python version in mac AND linux, which I think we can afford to avoid since nobody depends on this downstream afaict. Python builds only exist to test our own uniffi sanity.