Fix Redis cache deletion key

[LowKey88]

Summary

• fix incorrect key format when deleting generic cache entries

Testing

• python -m py_compile $(git ls-files '*.py')

---

https://chatgpt.com/codex/tasks/task_e_684421a3fd5c8323b7a2cb7e459a1697

[gemini-code-assist]

Hello @LowKey88, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request to help everyone get up to speed quickly. This PR, authored by LowKey88, addresses a bug related to the deletion of generic cache entries in Redis. Specifically, it fixes an incorrect key format being used when calling the r.delete function, ensuring that the correct key is targeted for deletion.

Highlights

• Bug Fix: The primary purpose of this PR is to fix a bug where the Redis key used for deleting generic cache entries was malformed, preventing successful deletion.
• Redis Key Format: The fix involves adding a missing separator (:) in the Redis key string constructed within the delete_generic_cache function.

Changelog

• utils/redis_utils.py
  • Fixed the Redis key format in the delete_generic_cache function by adding a colon (:) separator on line 53 to correctly match the expected key structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a critical issue in delete_generic_cache by aligning the Redis key format with that used in set_generic_cache and get_generic_cache. The addition of the colon in the f-string for the key on line 53 is essential for ensuring that cache entries can be reliably deleted. Without this fix, the delete operation would target an incorrect key. Well done on identifying and resolving this bug!

No specific style guide was provided for this repository. My review, by default, considers general Python best practices, largely aligned with PEP 8. The change in this PR adheres to these practices.

While reviewing this area of the code, I noticed a couple of opportunities for improving maintainability in utils/redis_utils.py that you might consider for future refactoring. These are outside the scope of the current diff but are relevant to the module:

1. Centralize Redis Key Prefix: The Redis key prefix (e.g., josancamon:rayban-meta-glasses-api:) is used in multiple functions (get_generic_cache, set_generic_cache, delete_generic_cache, get_reminder_keys, delete_reminder, set_cancellation_state, etc.). Defining this as a constant at the module level (e.g., REDIS_KEY_PREFIX = 'josancamon:rayban-meta-glasses-api:') would make it easier to manage, update, and prevent typos.
2. Helper Function for Key Generation: The logic for generating generic cache keys (base64 encoding of the path and decoding to UTF-8) is duplicated in get_generic_cache (lines 33-34), set_generic_cache (lines 42-43), and delete_generic_cache (lines 51-52). Extracting this into a private helper function (e.g., _generate_cache_key(path: str) -> str) would reduce redundancy and improve consistency.

These suggestions are for the broader module and not directly part of this PR's specific change, which is good to merge.

Summary of Findings

• Redis Key Prefix Repetition: The Redis key prefix (e.g., josancamon:rayban-meta-glasses-api:) is hardcoded and repeated across multiple functions in utils/redis_utils.py. This was observed in functions like get_generic_cache, set_generic_cache, delete_generic_cache, and others. Defining this as a module-level constant would improve maintainability. This is a medium severity maintainability concern. A specific review comment was not added as this pattern exists outside the changed lines in this PR.
• Cache Key Generation Duplication: The logic for generating generic cache keys (base64 encoding of the path) is duplicated in get_generic_cache, set_generic_cache, and delete_generic_cache. Extracting this into a private helper function would improve maintainability. This is a medium severity maintainability concern. A specific review comment was not added as this pattern exists outside the changed lines in this PR.

Merge Readiness

This pull request addresses a critical bug in cache key deletion and is well-targeted. The fix is correct and important for the application's caching behavior.

While the change itself is good to merge, I've noted a couple of medium-severity maintainability suggestions for the utils/redis_utils.py module in the general feedback and findings summary. These relate to centralizing the Redis key prefix and deduplicating key generation logic. Addressing these in a follow-up would be beneficial for the long-term health of the codebase.

Based on the review of the changes in this PR, it appears ready for merging. As I am not authorized to approve pull requests, please ensure appropriate testing and review by other team members before merging.