Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype: Interactive SVG map #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

GDur
Copy link

@GDur GDur commented Mar 20, 2023

Hello

This fork will make the SVG map interactive. This means the destination AstroBody circles and labeles are clickable.
As a hint, the "from" and "to" Dropdown menus have been removed visually.

The code is only a prototype/proof of concept, so it is not bullet proof atm.

Let's first see if this is a feature which other users find as desirable as I do. :)

Thank you for reviewing this fork.

Gregor

Made the SVG itself interactive by adding click eventlisteners to AstroBody Elements which will set the flight path accordingly.
@LoicViennois
Copy link
Owner

Thank you for your work, I think it can be a promising idea.
I will look into your PR when I find the time.

@LoicViennois
Copy link
Owner

Thank you for your great contribution. Starting from your code I created a version where we can select a destination with landing or not:

  • I made only the 'ground' and 'low-orbit' elements clickable to correspond to the path in the panel selection
    image
  • The 'landing' checkbox is automatically checked or not following mouse selection
  • I kept the right panel selection, I prefer this way for now, especially since the mobile version shows only the panel, and not the map

Branch: https://github.com/LoicViennois/KSP-DeltaV-Planner/tree/interactive

Feel free to test and give your feedback if you have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants