Skip to content

QA: Improve test coverage#14

Merged
LofoWalker merged 5 commits intomainfrom
qa/improve_test_coverage
Jan 29, 2026
Merged

QA: Improve test coverage#14
LofoWalker merged 5 commits intomainfrom
qa/improve_test_coverage

Conversation

@LofoWalker
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 28, 2026 00:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new unit/integration tests to increase coverage across security utilities, OAuth state handling, exception mappers, and a few domain value objects; also updates/cleans up test-related documentation.

Changes:

  • Add tests for JWT token service, bcrypt password hasher, OAuth state service, exception mappers, and invitation/membership IDs/tokens.
  • Add test-suite documentation under apps/api/src/test/README.md.
  • Remove the prior PR review analysis document and trim/update Copilot-Processing.md.

Reviewed changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
apps/api/src/test/java/com/upkeep/infrastructure/adapter/out/security/JwtTokenServiceTest.java Adds coverage for access/refresh token generation, validation, refresh error cases, and revocation.
apps/api/src/test/java/com/upkeep/infrastructure/adapter/out/security/BcryptPasswordHasherTest.java Adds unit tests for bcrypt hashing and verification.
apps/api/src/test/java/com/upkeep/infrastructure/adapter/out/oauth/InMemoryOAuthStateServiceTest.java Adds unit tests for OAuth state generation/consumption behavior.
apps/api/src/test/java/com/upkeep/infrastructure/adapter/in/rest/common/exception/GlobalExceptionMapperTest.java Adds tests validating status/error-code mapping for many domain exceptions.
apps/api/src/test/java/com/upkeep/infrastructure/adapter/in/rest/common/exception/ConstraintViolationExceptionMapperTest.java Adds tests for Bean Validation exception mapping to API errors.
apps/api/src/test/java/com/upkeep/domain/model/membership/MembershipIdTest.java Adds unit tests for MembershipId generation and parsing.
apps/api/src/test/java/com/upkeep/domain/model/invitation/InvitationTokenTest.java Adds unit tests for InvitationToken generation and validation.
apps/api/src/test/java/com/upkeep/domain/model/invitation/InvitationIdTest.java Adds unit tests for InvitationId generation and parsing.
apps/api/src/test/README.md Documents test structure and how to run tests/coverage.
PR-13-Review-Analysis.md Removes prior PR-review analysis document from the repo.
Copilot-Processing.md Updates the process log/status content; includes a note suggesting the file should be deleted after review.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LofoWalker LofoWalker merged commit 1b2275a into main Jan 29, 2026
3 checks passed
@LofoWalker LofoWalker deleted the qa/improve_test_coverage branch February 12, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants