Skip to content

build(deps): move nvapi to official nvidia repo #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 15, 2025

Description

This PR moves to the official nvapi repo, which did not exist at the time ours was created.

R560+ does not build with Sunshine as is, and unfortunately the R555 version in the official repo is missing the nvapi_interface.h file. See NVIDIA/nvapi#11

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.28%. Comparing base (a344e6c) to head (65bb410).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   11.61%   11.28%   -0.33%     
==========================================
  Files          92       69      -23     
  Lines       17337    12139    -5198     
  Branches     8100     5888    -2212     
==========================================
- Hits         2013     1370     -643     
+ Misses      14727    10270    -4457     
+ Partials      597      499      -98     
Flag Coverage Δ
Linux 11.28% <ø> (ø)
Windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants