Skip to content

Add logging to InfoController's Get method for better traceability #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Add logging to InfoController's Get method for better traceability #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd783b9
Add logging to InfoController's Get method for better traceability
LiteObject Apr 4, 2025
05630c5
Remove commented-out diff size check step from GitHub Actions workflow
LiteObject Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/code-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ jobs:
echo "$DIFF" >> $GITHUB_ENV
echo "EOF" >> $GITHUB_ENV

- name: Check Diff Size
id: check_diff_size
run: |
set -e
DIFF_SIZE=$(wc -c < change.diff)
echo "diff_size=$DIFF_SIZE" >> $GITHUB_OUTPUT
if (( DIFF_SIZE > 1000000 )); then
echo "Diff is too large, skipping review."
exit 0
fi
# - name: Check Diff Size
# id: check_diff_size
# run: |
# set -e
# DIFF_SIZE=$(wc -c < change.diff)
# echo "diff_size=$DIFF_SIZE" >> $GITHUB_OUTPUT
# if (( DIFF_SIZE > 1000000 )); then
# echo "Diff is too large, skipping review."
# exit 0
# fi

# Step 4: Output the diff (optional)
- name: Print diff
Expand Down
1 change: 1 addition & 0 deletions src/MyWebApi/MyWebApi/Controllers/WeatherForecastController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public InfoController(ILogger<InfoController> logger)
[HttpGet(Name = "Get")]
public IActionResult Get()
{
_logger.LogInformation("Hello World from InfoController!");
return Ok("Hello World");
}
}
Expand Down
Loading