feat: added error boundaries and tests#386
Open
theFirstCodeManiac wants to merge 1 commit into
Open
Conversation
|
@theFirstCodeManiac Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #87
Pull Request
Summary
Implemented branded global error and not-found boundaries to provide a consistent user experience aligned with the application's dark slate and cyan design system. Added comprehensive tests, centralized copy, documentation, and accessibility improvements.
Changes Made
Error Boundaries
app/error.jsas a client componentcomponents/ErrorBanner.jsxapp/copy/en.jsNot Found Page
app/not-found.jsapp/copy/en.jsGlobal Error Handling
app/global-error.jsto handle layout-level failuresLocalization
app/copy/en.jsTesting
app/error.test.tsxapp/not-found.test.tsxDocumentation
README.mdwith documentation for:Accessibility
ErrorBannerwithrole="alert"Testing
npm run lintnpm testnpm run buildAcceptance Criteria
app/error.jsapp/not-found.jsapp/global-error.jsapp/copy/en.jsREADME.md