Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Firefox signing without explicit id #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −1
Open

Added Firefox signing without explicit id #16

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ab1177
Added Firefox signing without explicit id
adamhwang Feb 18, 2020
ed5dda9
Updated readme
adamhwang Feb 18, 2020
1067d57
Merge branch 'LinusU:master' into master
adamhwang Jun 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added Firefox signing without explicit id
@adamhwang
adamhwang committed Feb 18, 2020
commit 8ab11776dfada1ee964de7db59787af74e94a026
5 changes: 5 additions & 0 deletions lib/firefox.js
View file
Original file line number Diff line number Diff line change
@@ -24,6 +24,11 @@ module.exports = async function (source) {
'--api-secret', process.env.WEXT_SHIPIT_FIREFOX_JWT_SECRET
]

if (process.env.WEXT_SHIPIT_FIREFOX_EXTENSION_ID) {
args.push('--id');
args.push(process.env.WEXT_SHIPIT_FIREFOX_EXTENSION_ID);
}

const spinner = ora('Loading web-ext tool...').start()

try {