-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed EINVAL error with fs.utimesSync() due to incorrect Unix timestamp #19
base: master
Are you sure you want to change the base?
Conversation
@mseminatore: Thanks for the PR. Two things:
|
@avik-das I can reproduce this using the following code:
c:\sepia-test>echo hello > a.txt I am not certain why this wasn't an issue either. Maybe the prior code works on other OS's or different Node versions. In any case the current NodeJS documentation is clear that Date.now() can't be used as is for atime and mtime. Snipped:
|
@avik-das OK, PR to your fork sent as well. |
As per the node.js documentation for `fs.utimes`: > The value should be a Unix timestamp in seconds. For example, > `Date.now()` returns milliseconds, so it should be divided by 1000 > before passing it in. I'm not sure why this wasn't causing a problem for most people, but it was reported by @mseminatore as a problem on Windows, on node.js v0.12.2. In any case, this fix doesn't cause a problem on Linux, on node.js v6.9.1, so I'm happy to make the fix.
- Added myself. - Added @delwyn, who had made a contribution earlier. - Added @mseminatore, who contributed recently.
Sync up with Avik-Das
@avik-das Do you have any contact with anyone who can accept this PR? It would be nice to have this fix integrated. |
@mseminatore - This repo appears to be abandoned. A couple of us created a fork called "replayer" to start accepting commits. You'll need to rename sepia=>replayer. Could you submit your PR there? |
@aneilbaboo I've not done this before. Can you share the specific steps that I would need to take? I assume it is more than simply renaming my forked repository. That won't connect my fork to your repo though will it? @avik-das Have you had any luck contacting the LinkedIn owners? |
@mseminatore - That won't work. I think this is right, but haven't checked it:
|
If you're having trouble or would just prefer me to do it, that's fine too. I took a look at the changes. They seem fine. |
This should address issue #17