fix challenge mode #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing check had wrong logic (don't do a NULL check with "if (pointer)") plus it was checking the wrong variable. Signed-off-by: Gert Doering <[email protected]>
When handling a server challenge, pam_linotp_validate_password() will call pam_linotp_get_authtok() with "token_length" set to 0 (unconditionally). pam_linotp_get_authtok() passes this on to pam_linotp_get_authtok_no_use_first_pass(), which will just error out in that case, doing nothing. Change pam_linotp_get_authtok_no_use_first_pass() to always do its job, and only check token_length when deciding whether or not to write back the token length to the caller (which is the only way this is used in the other caller, pam_sm_authenticate()). The whole purpose of the integer use of "token_len" in this context remains unclear (as the value written back is never used), but passing in always-0 and then always erroring-out is never useful. Signed-off-by: Gert Doering <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
challenge mode, like: entering an SMS pin, and getting back a challenge + text string, does not work due to two fairly obvious bugs.
If it works, the log looks like this:
Aug 7 17:39:20 openvpn-tcp pam_linotp[42195]: linotp:DEBUG: "result :-( 72399207995415978 sms submitted"
Aug 7 17:39:20 openvpn-tcp pam_linotp[42195]: linotp:DEBUG: "Challenge authentication for 'gert':::-( 723992"
Aug 7 17:39:20 openvpn-tcp pam_linotp[42195]: linotp:INFO: "Challenge authentication:'sms subm...' '72399207...'"
Aug 7 17:39:20 openvpn-tcp pam_linotp[42195]: linotp:DEBUG: "we are in challenge mode: 99"
Aug 7 17:39:20 openvpn-tcp pam_linotp[42195]: linotp:DEBUG: "challenge >sms submit< >7239920799< "
and, for example, OpenSSH will then nicely present "sms submitted" as next challenge, instead of just asking for "Your OTP:" again.