[이성] 멋쟁이 사자처럼 3번째 과제 제출 #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soriSeong
commented
May 15, 2022
soriSeong
commented
devHudi
requested changes
May 15, 2022
devHudi
left a comment
devHudi
left a comment
There was a problem hiding this comment.
지난주 과제 때 보다 훨씬 성장하신 것 같아요 👍
몇가지 수정하면 좋을 만한 점을 코멘트 달아드렸어요. 반영해주셔도 좋고, 참고만 해주셔도 좋습니다 😁
Comment on lines
+21
to
+25
| <MediaCard /> | ||
| </CardContainer> | ||
|
|
||
| </> | ||
| ); |
Comment on lines
+5
to
+16
| width: ${(props) => (props.width ? props.width : '48px')}; | ||
| height : ${(props) => (props.height ? props.height : '31px')}; | ||
| box-sizing: border-box; | ||
| border: 1px solid black; | ||
| border-radius : 2px; | ||
| padding : ${(props) => (props.padding ? props.padding : '0px')}; | ||
| margin : ${(props) => (props.margin ? props.margin : '0px')}; | ||
| text-align : center; | ||
| color : ${(props) => (props.color ? props.color : '#6c757d')}; | ||
| font-size : ${(props) => (props.fontSize ? props.fontSize : '14px')}; | ||
| background-color:${(props) => (props.backgroundColor ? props.backgroundColor : 'white')}; | ||
| text-align : ${(props) => (props.textAlign ? props.textAlign : 'center')}; |
There was a problem hiding this comment.
단톡방에 공유드린 short circuit evaluation 을 적용하여 코드를 줄여볼 수 있을 것 같아요 😎
Comment on lines
+20
to
+27
|
|
||
| const Button =(props) => { | ||
| return ( | ||
|
|
||
| <StyledButton width={props.width} height={props.height} color={props.color} fontSize={props.fontSize} backgroundColor={props.backgroundColor} textAlign={props.textAlign} padding={props.padding} margin={props.margin}>{props.children} </StyledButton> | ||
|
|
||
| ); | ||
| }; |
There was a problem hiding this comment.
혹시 Prettier 가 아직 적용이 안되어있나요? 담당 운영진에게 여쭈어보고 Prettier 를 적용해주세요! 🚨
Comment on lines
+50
to
+55
| `; | ||
|
|
||
|
|
||
|
|
||
|
|
||
| const MediaCard = (props) => { |
There was a problem hiding this comment.
이것 포함하여 전체적으로 의미없는 개행을 지워주시면 좋을 것 같습니다.
Comment on lines
+4
to
+22
| const StyledTime = styled.div` | ||
| color : #6c757d; | ||
| font-size : 13px; | ||
| border : 1px solid white; | ||
| text-align : center; | ||
| align-items : center; | ||
| margin-left : auto; | ||
| display: flex; | ||
| flex-direction : column; | ||
| justify-content : center; | ||
| `; | ||
|
|
||
| const TimeBox =(props) =>{ | ||
| return( | ||
| <StyledTime>{props.children}</StyledTime> | ||
| ); | ||
| }; | ||
|
|
||
| export default TimeBox; |
There was a problem hiding this comment.
Suggested change
| const StyledTime = styled.div` | |
| color : #6c757d; | |
| font-size : 13px; | |
| border : 1px solid white; | |
| text-align : center; | |
| align-items : center; | |
| margin-left : auto; | |
| display: flex; | |
| flex-direction : column; | |
| justify-content : center; | |
| `; | |
| const TimeBox =(props) =>{ | |
| return( | |
| <StyledTime>{props.children}</StyledTime> | |
| ); | |
| }; | |
| export default TimeBox; | |
| const TimeBox = styled.div` | |
| color : #6c757d; | |
| font-size : 13px; | |
| border : 1px solid white; | |
| text-align : center; | |
| align-items : center; | |
| margin-left : auto; | |
| display: flex; | |
| flex-direction : column; | |
| justify-content : center; | |
| `; | |
| export default TimeBox; |
TimeBox 컴포넌트는 단순히 StyledTime 에 props 를 그대로 전달해주는 역할만하고 있어요. 위와 같이 코드를 개선해볼 수 있을 것 같아요 😁
|
웹페이지 상하좌우에 흰색 여백이 존재하는 것 같아요. |
ReadMe 작성
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.