Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix and rename sdk test to anchor sdk test #1645

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Mar 11, 2025

Changes:

  • renamed sdk-test -> anchor-sdk-test
  • made anchor optional in light-sdk

@ananas-block ananas-block force-pushed the jorrit/feat-sdk-remove-anchor branch from 106d02c to afe3274 Compare March 11, 2025 15:33
"examples/anchor/memo",
# "examples/anchor/name-service-without-macros",
# "examples/anchor/counter",
# "examples/anchor/memo",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented on purpose will fix once sdk refactor is complete

ctx.accounts.get_account_compression_program().clone(),
ctx.accounts.self_program.to_account_info(),
ctx.accounts.get_system_program().clone(),
];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not going to stay this way. I will remove the light_system_accounts macro in a different pr and pass all system accounts via remaining accounts in anchor programs so that passing system accounts is consistent in anchor and non anchor programs.

@ananas-block ananas-block force-pushed the jorrit/feat-sdk-remove-anchor branch from afe3274 to 433328d Compare March 11, 2025 15:41
@ananas-block ananas-block marked this pull request as ready for review March 11, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant