Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add batch compress tokens #1563

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: add batch compress tokens #1563

wants to merge 8 commits into from

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Feb 7, 2025 •
edited
Loading

State

  • ready, just in draft until final review to allow a clean commit for the audit

@ananas-block ananas-block force-pushed the jorrit/feat-batch-compress-tokens branch from 66c2bdf to 37359e5 Compare February 12, 2025 23:25
@ananas-block ananas-block marked this pull request as draft February 13, 2025 13:51
SwenSchaeferjohann
SwenSchaeferjohann reviewed Feb 13, 2025
View reviewed changes
programs/compressed-token/src/lib.rs Outdated
process_mint_to::<COMPRESS>(
ctx,
inputs.pubkeys.as_slice(),
inputs.amounts.as_slice(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ananas-block is inputs.amounts having multiple amounts?
ideally for this ix we just have a single inputs.amount and apply it for all recipients

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I can add an option for that

@ananas-block ananas-block marked this pull request as ready for review February 13, 2025 22:28
@ananas-block ananas-block marked this pull request as draft February 13, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwenSchaeferjohann SwenSchaeferjohann SwenSchaeferjohann left review comments

@sergeytimoshin sergeytimoshin Awaiting requested review from sergeytimoshin sergeytimoshin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @SwenSchaeferjohann