Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes
UnderReviewWarning
fromwarn_missing_pkg
. As far as I can tell, this function is meant to be an internal warning method for other parts of the library to use, and only triggers when theWARN_MISSING_PACKAGE
env var is set to something nonzero. Unfortunately, it's also used in many parts oflightning-bolts
, and so I (as a user) get maybe 5-10UnderReviewWarning
s every time I import a module, even ifwarn_missing_pkg
wouldn't have warned me about anything otherwise.The underlying issue is discussed in #563. The current PR does not fix all of #563, but will ameliorate the problem for some users (so #563 should stay open).
Before submitting
(docs/tests/changelog not touched because this PR doesn't introduce a new feature or any backwards-incompatible changes)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃