Skip to content

fix add not rendered ipynb [if unsupported accel] #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2021
Merged

fix add not rendered ipynb [if unsupported accel] #54

merged 5 commits into from
Jul 17, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 12, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #51

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug / fix Something isn't working ci/cd labels Jul 12, 2021
@Borda
Copy link
Member Author

Borda commented Jul 13, 2021

in principle, we shall run all accelerators in sequence, each accelerator serves its notebooks (which it can render/serve) and the last one will commit the remaining even they are empty...

@Borda Borda marked this pull request as ready for review July 17, 2021 06:48
@Borda Borda requested a review from ethanwharris as a code owner July 17, 2021 06:48
@Borda Borda requested review from kaushikb11 and a team July 17, 2021 06:48
@Borda Borda merged commit 2987383 into main Jul 17, 2021
@Borda Borda deleted the ci/accel branch July 17, 2021 06:56
@Borda Borda changed the title copy unsupported accel fix add not rendered ipynb [if unsupported accel] Jul 17, 2021
pl-ghost pushed a commit that referenced this pull request Jul 17, 2021
Borda added a commit to phlippe/lightning-tutorials that referenced this pull request Jul 26, 2021
Borda added a commit to phlippe/lightning-tutorials that referenced this pull request Jul 27, 2021
tchaton pushed a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Borda added a commit that referenced this pull request Jul 27, 2021
* Adding GNN tutorial

* Removing starters folder

* Adding Deep Autoencoder Tutorial

* Compressing GIF

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Correcting imports

* Compressing JPEG image

* Making GPU optional

* Adding device variable

* inline image to notebooks (#60)

* image b64
* allow URL
* readme

Co-authored-by: Roger Shieh <[email protected]>

* improve pruning removed notebooks (#61)

* fix dirs
* rename template
* fix parent

* fix add not rendered ipynb [if unsupported accel] (#54)

* merge --ff
* fix: merge add
* try TPU

* long lines

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Roger Shieh <[email protected]>
Co-authored-by: Jirka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ci/cd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to render with unsupported accel
2 participants