Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 3, 2025

What does this PR do?

The installation is much faster, so the cost is also lower
also we would be able to drop building GPU images for CI

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21158.org.readthedocs.build/en/21158/

Copy link
Contributor

github-actions bot commented Sep 3, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to tests/tests_pytorch/plugins/precision/test_fsdp.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | oldest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to tests/tests_pytorch/plugins/precision/test_fsdp.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the title run Pytorch tests for oldest on T4_x_4 run Pytorch tests for oldest on T4_X_4 [wip] Sep 3, 2025
@Borda Borda changed the title run Pytorch tests for oldest on T4_X_4 [wip] run Pytorch tests for oldest on T4_X_4 Sep 3, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 4, 2025
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (663b6ce) to head (42493af).
⚠️ Report is 10 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (663b6ce) and HEAD (42493af). Click for more details.

HEAD has 357 uploads less than BASE
Flag BASE (663b6ce) HEAD (42493af)
cpu 108 27
python 12 3
lightning_fabric 25 0
pytest 56 0
python3.12 12 3
python3.10 24 6
python3.12.7 36 9
lightning 61 15
python3.11 24 6
gpu 2 0
pytorch2.1 12 6
pytest-full 54 27
pytorch2.2.2 6 3
pytorch_lightning 24 12
pytorch2.7 6 3
pytorch2.8 6 3
pytorch2.3 6 3
pytorch2.5.1 6 3
pytorch2.4.1 6 3
pytorch2.6 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21158     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         269      266      -3     
  Lines       23595    23601      +6     
=========================================
- Hits        20582    18606   -1976     
- Misses       3013     4995   +1982     

@Borda Borda changed the title run Pytorch tests for oldest on T4_X_4 run Pytorch tests for oldest with ... [wip] Sep 4, 2025
@Borda Borda changed the title run Pytorch tests for oldest with ... [wip] litGPU: run Pytorch tests with ... [wip] Sep 5, 2025
@Borda Borda changed the title litGPU: run Pytorch tests with ... [wip] litGPU: run Pytorch tests with uv setup Sep 5, 2025
@Borda Borda merged commit d23fec1 into master Sep 5, 2025
78 of 80 checks passed
@Borda Borda deleted the ci/pytorch-T4_x_4 branch September 5, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants