Skip to content

feat[logger] update mlflow limit for parameters length log #20636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bastienjalbert
Copy link

@bastienjalbert bastienjalbert commented Mar 11, 2025

feat[logger] update mlflow limit for parameters length log using mlflow package

What does this PR do?

Update the mlflow logger to take into account limits defined inside mlflow package. As of now, it only include limit for params logging.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs) Not needed
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request? No breaking changes because of fallback
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20636.org.readthedocs.build/en/20636/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 11, 2025
@bastienjalbert
Copy link
Author

bastienjalbert commented Mar 26, 2025

@lantiga, @Borda, @tchaton, @justusschock, @ethanwharris, is there any change to see this pull request merged for the next release ?

@Borda
Copy link
Member

Borda commented Apr 7, 2025

@bastienjalbert seems some tests are still failing :)

@Borda Borda added the waiting on author Waiting on user action, correction, or update label Apr 7, 2025
@bastienjalbert
Copy link
Author

True, I'll make patchs in coming days. I think that just a mock issue.
Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package waiting on author Waiting on user action, correction, or update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants