Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated model_checkpoint.py to add the facility of retaining periodic checkpoints #20547

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

updated model_checkpoint.py to add the facility of retaining periodic checkpoints #20547

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bc6e9f
updated model_checkpoint.py to add the facility of retaining periodic…
arijit-hub Jan 14, 2025
c873f5d
Merge branch 'master' into retain_periodic_ckpt
lantiga Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/lightning/pytorch/callbacks/model_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ class ModelCheckpoint(Checkpoint):
If this is ``False``, then the check runs at the end of the validation.
enable_version_counter: Whether to append a version to the existing file name.
If this is ``False``, then the checkpoint files will be overwritten.
retain_periodic_ckpt: Whether to retain the periodic checkpoints when multiple checkpoints are
saved. If this is ``False``, then only the latest checkpoint will be saved. If this is ``True``,
don't change the default value of ``save_top_k``.
Default: ``False``.

Note:
For extra customization, ModelCheckpoint includes the following attributes:
Expand Down Expand Up @@ -228,6 +232,7 @@ def __init__(
every_n_epochs: Optional[int] = None,
save_on_train_epoch_end: Optional[bool] = None,
enable_version_counter: bool = True,
retain_periodic_ckpt: bool = False,
):
super().__init__()
self.monitor = monitor
Expand All @@ -247,6 +252,7 @@ def __init__(
self.best_model_path = ""
self.last_model_path = ""
self._last_checkpoint_saved = ""
self.retain_periodic_ckpt = retain_periodic_ckpt

self.kth_value: Tensor
self.dirpath: Optional[_PATH]
Expand Down Expand Up @@ -714,7 +720,12 @@ def _save_none_monitor_checkpoint(self, trainer: "pl.Trainer", monitor_candidate
previous, self.best_model_path = self.best_model_path, filepath
self._save_checkpoint(trainer, filepath)

if self.save_top_k == 1 and previous and self._should_remove_checkpoint(trainer, previous, filepath):
if (
self.save_top_k == 1
and not self.retain_periodic_ckpt
and previous
and self._should_remove_checkpoint(trainer, previous, filepath)
):
self._remove_checkpoint(trainer, previous)

def _update_best_and_save(
Expand Down