fix(extensions-library): add setup hooks for jupyter and dify#567
Open
yasinBursali wants to merge 1 commit intoLight-Heart-Labs:resources/devfrom
Open
fix(extensions-library): add setup hooks for jupyter and dify#567yasinBursali wants to merge 1 commit intoLight-Heart-Labs:resources/devfrom
yasinBursali wants to merge 1 commit intoLight-Heart-Labs:resources/devfrom
Conversation
jupyter: fix manifest contradiction (required: false vs compose :?) and add setup.sh to auto-generate JUPYTER_TOKEN. dify: add setup.sh to auto-generate DIFY_SECRET_KEY. Service remains disabled (compose.yaml.disabled) but the hook prepares secrets for when users enable it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
yasinBursali
force-pushed
the
ext/fix-setup-hooks-c2
branch
from
9c7df73 to
566a5ef
Compare
Contributor
Author
|
Rebased on latest resources/dev (af07063). This PR has no file overlap with any other open PR and can be merged independently in any order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix jupyter manifest contradiction and add setup.sh hooks for jupyter and dify.
Why
JUPYTER_TOKENasrequired: falsebut compose uses:?(hard fail). Users hit a compose error despite the manifest suggesting the token is optional.DIFY_SECRET_KEYcorrectly declared as required but no auto-generation. Service is disabled (compose.yaml.disabled) but the hook prepares secrets for when users enable it.How
required: falsetorequired: truein manifest, addedsetup_hook: setup.shsetup_hook: setup.shto manifestsetup.shscripts usingopenssl rand -hex 32for both servicesScope
All changes within
resources/dev/extensions-library/services/{jupyter,dify}/.Testing
.env, verify compose starts, verify Jupyter UI accepts generated tokenReview
Critique Guardian: APPROVED WITH WARNINGS (minor: dify hook runs on all installs even when disabled — intentional)
Suggested merge order
Independent of other batch C PRs.