test(settings-api): add pytest suite for settings, voice, and model-swap endpoints#452
Closed
buddy0323 wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Closed
test(settings-api): add pytest suite for settings, voice, and model-swap endpoints#452buddy0323 wants to merge 2 commits intoLight-Heart-Labs:mainfrom
buddy0323 wants to merge 2 commits intoLight-Heart-Labs:mainfrom
Conversation
Collaborator
|
Closing as part of v2.1.0 stabilization. We're pausing new feature PRs while we solidify the installer and CI gates. If this is still relevant for v2.2.0 (targeting April 1), please rebase and resubmit. Thank you for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/test_settings.py— 456-line pytest suite coveringenv_utilshelpers,GET/PATCH /api/settings,GET/PATCH /api/settings/voice, andPOST /api/model/swapenv_utils.py— shared helpers for reading/writing.envand loading/validating against.env.schema.json(no shell evaluation; pure regex)routers/settings.py—GET /api/settingsandPATCH /api/settings; secret keys (from schema"secret": true) are stripped from every responserouters/voice_settings.py—GET /api/settings/voiceandPATCH /api/settings/voice; all fields validated against.env.schema.jsonbefore any write; rejects the whole request if any field fails (no partial writes)routers/model_swap.py—POST /api/model/swap; tier whitelist validated before any subprocess is launched; streamsdream-clioutput as SSE; ANSI codes stripped from log eventsmodels.pywithSettingsResponse,SettingsPatch,VoiceSettingsResponse,VoiceSettingsPatch,ModelSwapRequestmain.pyto register all three new routers.env.schema.jsonwithWHISPER_MODELenum andWHISPER_VAD_THRESHOLDnumber boundsTest plan
GET /api/settingsreturns all required fields (llm_model,mode,tier,gpu_backend,enabled_services,voice_enabled,rag_enabled)GET /api/settings— secret values (WEBUI_SECRET,LITELLM_KEY,OPENCLAW_TOKEN, …) are absent from the raw response body and not present as response keysPATCH /api/settingswithmode: "cloud"→DREAM_MODE=cloudwritten to.env; response reflects new valuePATCH /api/settingswith invalidmode: "turbo"→ 422;.envunchangedPATCH /api/settingswith both invalidmodeand blankllm_model→ 422 with two errors (no partial write)GET /api/settings/voicefalls back to schema defaults when keys are absent; returnsallowed_whisper_modelslist from schemaPATCH /api/settings/voicewithwhisper_model: "giant"→ 422 with "must be one of" messagePATCH /api/settings/voicewithwhisper_vad_threshold: 1.5→ 422; valid boundaries0.0and1.0are acceptedPATCH /api/settings/voicewith one invalid field alongside valid fields → no partial writePOST /api/model/swapwith unknown tier → 422 containing the bad tier namePOST /api/model/swapwhendream-clinot found → 501POST /api/model/swapstreamstext/event-stream; final event hastype: "done"on success ortype: "error"on non-zero exit; ANSI codes stripped from log events;cache-control: no-cacheheader present