fix(token-spy): replace broad exception handlers with specific types#449
Closed
bugman-007 wants to merge 1 commit intoLight-Heart-Labs:mainfrom
Closed
fix(token-spy): replace broad exception handlers with specific types#449bugman-007 wants to merge 1 commit intoLight-Heart-Labs:mainfrom
bugman-007 wants to merge 1 commit intoLight-Heart-Labs:mainfrom
Conversation
Collaborator
|
Closing as part of v2.1.0 stabilization. We're pausing new feature PRs while we solidify the installer and CI gates. If this is still relevant for v2.2.0 (targeting April 1), please rebase and resubmit. Thank you for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
except Exception:with specific exception typesChanges
except (json.JSONDecodeError, ValueError)instead ofexcept Exceptionexcept (FileNotFoundError, IOError, PermissionError)instead ofexcept Exceptionexcept (IOError, PermissionError, OSError)instead ofexcept ExceptionRationale
The original code used broad
except Exception:handlers at I/O boundaries. While catching exceptions at I/O boundaries is acceptable per CLAUDE.md, they must be specific exception types that map to distinct, meaningful statuses.Test plan