Skip to content

fix(dashboard-api): remove broad exception handler from api_status#444

Closed
bugman-007 wants to merge 1 commit intoLight-Heart-Labs:mainfrom
bugman-007:fix/dashboard-api-exception-handling
Closed

fix(dashboard-api): remove broad exception handler from api_status#444
bugman-007 wants to merge 1 commit intoLight-Heart-Labs:mainfrom
bugman-007:fix/dashboard-api-exception-handling

Conversation

@bugman-007
Copy link
Contributor

Summary

  • Removes broad except Exception: handler from /api/status endpoint
  • Complies with CLAUDE.md: "No broad or silent catches"
  • Lets errors propagate with full stack traces for debugging

Rationale

The current code catches all exceptions and returns a safe fallback payload to prevent the dashboard from showing "0/17 services". However:

  1. This violates the project's error handling philosophy
  2. The dashboard has error boundaries that handle failures gracefully
  3. Silent fallbacks hide real issues and make debugging harder

Changes

  • Removed try/except wrapper from api_status()
  • Simplified docstring to reflect new behavior
  • Errors now propagate as HTTPException with full context

Test plan

  • make lint passes
  • Manual test: dashboard loads status correctly
  • Manual test: dashboard handles API errors gracefully
  • Verify error boundaries catch failures without "0/17" flash

@Lightheartdevs
Copy link
Collaborator

Closing as part of v2.1.0 stabilization. We're pausing new feature PRs while we solidify the installer and CI gates. If this is still relevant for v2.2.0 (targeting April 1), please rebase and resubmit. Thank you for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants