Repository navigation
fix(MathJax): copy MathJax's mtable styles so arrays don't render as … - #129
Merged
Merged
Conversation
jakeaturner
requested review from
ethanaturner
and
a balanced review from Copilot
November 12, 2026 21:00
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The MathJax PDF table-styling changes have no active review issues.
No open issues 🎉
What changed in this PR
Restores MathJax table styling in generated PDFs so arrays and matrices render correctly after body-only HTML extraction drops MathJax’s stylesheet.
Changes:
- Adds stroke and fill rules to prevent black frames and invisible table lines.
- Restores dashed and dotted borders and allows nested table SVGs to overflow visibly.
| File | Description |
|---|---|
src/styles/pdf-page.css |
Adds MathJax table styles for frames, borders, and nested SVG overflow. |
Review effort: Balanced
ethanaturner
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…black boxes