Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize signature stamp #4772

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

vitormattos
Copy link
Member

@vitormattos vitormattos commented Mar 28, 2025

Administration settings page of LibreSign about this feature:

Screenshot_20250402_234037

to-do

@vitormattos vitormattos added this to the Next Major (32) milestone Mar 28, 2025
@vitormattos vitormattos self-assigned this Mar 28, 2025
@vitormattos vitormattos force-pushed the feat/customize-signature-stamp branch 8 times, most recently from 7e47a76 to a8a198e Compare April 2, 2025 21:07
If the metadata field of a sign request is null, the array_merge
function will throws an error because wait for an array as argument.

Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feat/customize-signature-stamp branch from c1f521f to c756ff7 Compare April 3, 2025 00:18
This condition was added before only to don't throw errors at unit tests
because we wasn't sent a real pdf file at tests

Signed-off-by: Vitor Mattos <[email protected]>
When the page is 1, the default value is 1 and isn't necessary

Signed-off-by: Vitor Mattos <[email protected]>
Neve will be description only because we have a signature stamp created
by signer. For now, isn't possible disable to signer create a signature
stamp if we have the necessary conditions to add a visible signature.

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos force-pushed the feat/customize-signature-stamp branch from 086ce48 to de66a62 Compare April 3, 2025 02:26
@vitormattos vitormattos marked this pull request as ready for review April 3, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 0. Needs triage
Development

Successfully merging this pull request may close these issues.

1 participant