removed white spaces in menu header (fixes Issue #1536)

[maggienegm]

The white spaces (which is actually the primary color chosen in the Global settings) in the menu header and around the user's name have been removed and no longer show no matter the screen size. It now looks like this:

Full Screen View

Less than Full Screen but Menu isn't Hidden View

Hidden Menu View

[maggienegm]

I may have found a bug while working on this, but would like it if someone else could confirm it's a bug.

I believe that the primary color chosen in the Global Settings (Administration > Globals > Appearance tab > Primary color) isn't showing properly in the menu header. The Global Settings allow you to choose a different color than the default one (the tan color above - #fedf98), but it doesn't show in the app.

I believe it's because when the app is first loaded, there's a call to the style.php file with preloaded color choices, as shown below:

However, I was unsuccessful in locating the original call to style.php. The inspector says it came form main.php, but I can't find the call to style.php in there. So, I'm stuck and would appreciate any help!

[KoniKodes]

@muarachmann @Ngai-E @VirginiaBalseiro Can someone help Maggie track down this issue?

[maggienegm]

I may have found a bug while working on this, but would like it if someone else could confirm it's a bug.

I believe that the primary color chosen in the Global Settings (Administration > Globals > Appearance tab > Primary color) isn't showing properly in the menu header. The Global Settings allow you to choose a different color than the default one (the tan color above - #fedf98), but it doesn't show in the app.

I believe it's because when the app is first loaded, there's a call to the style.php file with preloaded color choices, as shown below:

However, I was unsuccessful in locating the original call to style.php. The inspector says it came form main.php, but I can't find the call to style.php in there. So, I'm stuck and would appreciate any help!

I've since then figured out the user preferences takes priority over the global settings, so this is no longer an issue.

[KoniKodes]

Then do we want to close this?

[maggienegm]

Not yet! The original issue's PR solution stills needs to be checked.

[KoniKodes]

Oh. Alright.