Fixed filter function of the Patient List Reports module #1497
Conversation
| } else { | ||
| $query .= "LEFT OUTER JOIN form_encounter AS e ON " . | ||
| "e.pid = p.pid "; | ||
| $query .= "LEFT OUTER JOIN libreehr_postcalendar_events AS e ON " . |
There was a problem hiding this comment.
Will test this when i can. Can you repopulate back the fields with the search criteria? e.g if you chosed a date it should fill back after the search is done.
There was a problem hiding this comment.
Thank you, and I can do that. I will push those changes when I'm done.
|
|
I have created an issue report regarding the form accepting invalid date ranges: #1499 |
library/report_functions.php
Outdated
| echo "<td class='label'>"; | ||
| echo xlt('From'); | ||
| echo ": | ||
| </td> | ||
| <td> | ||
| <input type='text' name='form_from_date' id='form_from_date' size='10' | ||
| value='"; htmlspecialchars(oeFormatShortDate(attr($from_date))); | ||
| echo "' /> | ||
| value='"; echo $from_date; |
There was a problem hiding this comment.
Hmmm something seems not right here ....
There was a problem hiding this comment.
I believe I fixed this. I just pushed a change!
| "i1.date AS idate1, i2.date AS idate2, " . | ||
| "c1.name AS cname1, c2.name AS cname2 " . | ||
| "FROM patient_data AS p "; | ||
|
|
||
| if (!empty($from_date)) { | ||
| $query .= "JOIN form_encounter AS e ON " . |
There was a problem hiding this comment.
Y did you delete the query? any specific reasons @mhn94, I think it did the Job.
There was a problem hiding this comment.
@muarachmann Maggie has applied for the new Outreachy round, so we can't communicate with her until she's officially announced as an applicant on Oct. 1st.
Is there anyway to fix this before then?
There was a problem hiding this comment.
Y did you delete the query? any specific reasons @mhn94, I think it did the Job.
I deleted it because it wasn't displaying the right data when I ran the app on my machine. Most of the time, it wouldn't pull any appointment info when there should have been. Does the original query work for you?
I changed the db to "libreehr_postcalendar_events," because I saw that when new events are created/old events are edited (in /modules/calendar/add_edit_event.php), this db was used. For me, the new query seems to be displaying the correct info.
|
Well without wanting to spoil anything or take any credits, she could get
back on this on October 1st.
Let me know if it is urgent
…On Wed, Aug 28, 2019 at 4:06 PM Toni Shortsleeve ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In interface/reports/reports_controllers/PatientListController.php
<#1497 (comment)>:
> "i1.date AS idate1, i2.date AS idate2, " .
"c1.name AS cname1, c2.name AS cname2 " .
"FROM patient_data AS p ";
if (!empty($from_date)) {
- $query .= "JOIN form_encounter AS e ON " .
@muarachmann <https://github.com/muarachmann> Maggie has applied for the
new Outreachy round, so we can't communicate with her until she's
officially announced as an intern on Oct. 1st.
Is there anyway to fix this before then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1497?email_source=notifications&email_token=AD4X4XUFOEWSQWDI3XFNZCTQG2IBFA5CNFSM4ILGKUH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCC7DITA#discussion_r318635406>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AD4X4XQKD4KHFTMI63TQVILQG2IBFANCNFSM4ILGKUHQ>
.
|
|
It's more frustrating than anything right now. We can wait until she's back - hope she's accepted! |
… fix-patient-list-reports-filter
|
@muarachmann @Ngai-E Can you check this please? |
Fixes Issue #1496
Before, the Patient List Report module would show the same results no matter the input. Now, the module filters correctly accordingly to input.
For example, now: