Updating + relocating icon assets #1272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aethelwulffe here is one of the gci task might take me long to test this. Can you do so. |
aethelwulffe
suggested changes
Jan 23, 2019
There was a problem hiding this comment.
Hi @JonathanXu1
Tell me, do you think we can move these image assets to /assets/images/somedirectoryforrelatedfiles? We have been get that type of asset pulled out of /interface or /pic or any of the number of other spots, then identify where the images are used (subdir like /core or /featurename etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is done as part of this Google Code-In Issue:
https://gitlab.com/librehealth/outreach/gci/issues/51
I've replaced most icons in the /images folder and some in the interface/pic folder with newer PNG variants from Fonts Awesome. I've also linked redundant icons with similar uses to the assets in the /images folder.
This is my first pull request, please let me know if there's anything I should change/fix to do it properly. Thanks!