Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appointment's tooltip display styles #1198

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

apooravc
Copy link
Contributor

@apooravc apooravc commented Jul 1, 2018

Added 4 display styles for an appointment's tooltip, like an appointment's slot text has. Also, in case of provider events, there wasn't a check for including comment, if there is one, in event's tooltip which is added in this commit.

@teryhill Please have a look. I also noticed that the event's category+comment becomes a part of hyperlink along with name, probably because of including them in $e['title'] instead of $e['e_info'] in switch cases in get_provider_event.php:
text

Could you test if it's appearing like above on your machine as well? Including status, name in hyperlink or in $e['title'] and rest - event's category+comment in $e['e_info'] would separate them and all of them would be governed as per Appointment Display Style global.

@aethelwulffe
Copy link
Contributor

I will pull this today.

@aethelwulffe
Copy link
Contributor

We are looking to see what can be come up with for implementing tooltips in cool and useful ways.

@apooravc
Copy link
Contributor Author

@teryhill @aethelwulffe There's a tooltip plugin qTip2 which has a cool layout as shown below:
qtip

So, the details of an appointment could be represented in above layout with image of patient on left side and description of appointment with its details - category, status, comment, facility on right side. Should we use it or implement a layout like that internally?

@teryhill
Copy link
Contributor

Can you bring the asset in first and let us see how large it is? Any other places that you can think to use it?

@apooravc
Copy link
Contributor Author

@teryhill qTip's css file is 2 KB and js file is 26 KB and are added with last commit. It can be used as a default tooltip plugin across EHR for displaying simple info. texts (as in Globals), HTML with images, links (in Calendar) and it can also be used to fetch dynamic medical info./data from web via AJAX. Or we may improve the current tooltip layout used in Calendar.

Also, appt. display is changed from:
text
to:
apptd
so that only status and patient's name is in hyperlink, according to globals.

@apooravc
Copy link
Contributor Author

apooravc commented Jul 27, 2018

Latest commit replaces native Calendar tooltip with qTip.
Previews:

  1. Patient event tooltip with profile image and non-empty comment:
    pic1

  2. Patient event tooltip without profile image and empty comment:
    pic2

  3. Provider event tooltip with empty comment:
    pic3

In case of appointment (patient event) tooltips, content depends on Appointment Tooltip Display Style global which is set to show everything in this case. We could also add facility, billing facility in tooltip.

@teryhill Please have a look.

@aethelwulffe
Copy link
Contributor

We have, or have had qtip in the code before.
This PR is pretty light. Testing now for basic operation.

With fullcalendar project, have you inquired with them as to using qtip in their project (and why they didn't)?

@aethelwulffe
Copy link
Contributor

I think the old qtip was in the ZEND stuff, so nothing to dump.
In my minimal use-case test, this works nice. I have the outstanding question based on the fullcalendar project, but otherwise this seems real good to me.

Copy link
Contributor

@aethelwulffe aethelwulffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day we should switch from "pc_calendar" to "fc_calendar".

@aethelwulffe
Copy link
Contributor

Would someone test this and do a review Pretty Please?

@aethelwulffe
Copy link
Contributor

Fixed conflicts here. Can I get a second review on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants