Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to save all updates made to misc_billing_options form #1126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added ability to save all updates made to misc_billing_options form #1126

wants to merge 1 commit into from

Conversation

Trodrige
Copy link
Collaborator

@Trodrige Trodrige commented May 16, 2018

Fixing #1111
Added ability to save all updates made to misc_billing_options form in log_form_misc_billing_options table

@Trodrige Trodrige requested review from aethelwulffe and teryhill May 16, 2018 07:41
@Trodrige
Copy link
Collaborator Author

@teryhill I know you have changes you want me to make here.

Copy link
Contributor

@aethelwulffe aethelwulffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How/when does this table get installed?

@Trodrige
Copy link
Collaborator Author

@aethelwulffe still to do that. I think the table will be created when the first misc_billing_options form is ever updated.

@teryhill
Copy link
Contributor

@Trodrige can you set up a check to see if anything has been changes then save the record. Also an indicator on the log of what was changed may be helpful.

@aethelwulffe
Copy link
Contributor

This lists "unknown repository" as the branch source... ???

@aethelwulffe
Copy link
Contributor

Do we have an update on this @Trodrige

@aethelwulffe
Copy link
Contributor

Shall I test this?

Copy link
Contributor

@aethelwulffe aethelwulffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should kill the log table before re-testing this, Ja?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants