Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating UI-Editor #1117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

2208Abhinav
Copy link
Contributor

UI-Editor for the software

@apooravc
Copy link
Contributor

I tested it with my system @2208Abhinav in Fee Sheet, the positive type shows green as it should but after making it color red from the editor and saving it, upon refreshing of Fee Sheet tab, all buttons appear grey.
Before:
before
After:
after

Other things such as menu link and real time changes within the editor are working properly.

@aethelwulffe
Copy link
Contributor

This is due to a non-bootstrap button property (background). /modules/MIPS/measures_select.php had the same issue (thus only worked with the purple theme, otherwise had grey and white css buttons), which is an issue I corrected and am going to push with new commits soon. Removing the background property, probably declared in the fee_sheet/new.php somewhere should take care of this. Bootstrap and all.

@aethelwulffe
Copy link
Contributor

Let me just say that all the UI tweaker bits we have been adding lately have been very good to see. This has been a neglected area for a long time, and all this effort is making a huge difference.

@2208Abhinav
Copy link
Contributor Author

@aethelwulffe sorry I was away from solving the bugs here for sometime, was busy with GSOC project. I will try to solve the bugs here now.

@aethelwulffe
Copy link
Contributor

We can hang onto this PR just fine. It is non-critical, and you have to prioritize.

Copy link
Contributor

@naveen17797 naveen17797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aethelwulffe i have tested this PR with the new developer mode, as @apooravc told, the buttons are turning gray and also there is no real time color update on the editor

@aethelwulffe
Copy link
Contributor

Bump.
Folks looking at the Theme and UI stuff should really review this.

Copy link
Contributor

@aethelwulffe aethelwulffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this another bump. It is headed in the right direction, and I don't want to drop it as stale. Can we please fix the greyout issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants