S3 support and duplicate error dialog on extraction #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…folder-error Add duplicate error dialog on extraction
…folder-error Protects before relative paths and trims the string
* added changelog and fixed composer.json * fixed translation for title
* now supports s3 * prevent empty string in dialog + log successful extraction
# Conflicts: # js/extraction.js # lib/Controller/ExtractionController.php
N21 141 s3 support
arnegns
changed the title
|
Hi @PaulLereverend could you review this PR? |
|
+1 |
|
any update on this? @PaulLereverend ping :) |
|
Sounds good to me if you can resolve the conflits |
…uplicate-folder-error # Conflicts: # CHANGELOG.md # appinfo/info.xml # js/extraction.js # l10n/ar.js # l10n/ar.json # l10n/bg.js # l10n/bg.json # l10n/ca.js # l10n/ca.json # l10n/da.js # l10n/da.json # l10n/de.js # l10n/de.json # l10n/de_DE.js # l10n/de_DE.json # l10n/el.js # l10n/el.json # l10n/en_GB.js # l10n/en_GB.json # l10n/es.js # l10n/es.json # l10n/eu.json # l10n/fi.js # l10n/fi.json # l10n/he.js # l10n/he.json # l10n/hr.js # l10n/hr.json # l10n/hu.js # l10n/hu.json # l10n/is.js # l10n/is.json # l10n/it.js # l10n/it.json # l10n/ja.js # l10n/ja.json # l10n/ko.js # l10n/ko.json # l10n/mk.js # l10n/mk.json # l10n/nl.js # l10n/nl.json # l10n/pl.js # l10n/pl.json # l10n/sc.js # l10n/sc.json # l10n/sk.js # l10n/sk.json # l10n/sl.js # l10n/sl.json # l10n/sv.js # l10n/sv.json # l10n/tr.js # l10n/tr.json # l10n/uk.js # l10n/uk.json # l10n/zh_CN.js # l10n/zh_CN.json # lib/Controller/ExtractionController.php
|
@PaulLereverend master is merged. can you have a look? |
…folder-error update newestes extract master into our extract plugin
…uplicate-folder-error # Conflicts: # l10n/de.js # l10n/de.json # l10n/he.json
|
Ping @PaulLereverend |
|
Hey @PaulLereverend can you please merge this pr? |
|
Hey @arnegns , we recently took extract maintainance into our hands and would love to have the work you've done merged into the main branch, but sinse a lot of things changed from the last commit to now, we can't just merge it as it is. Would you still be interested in updating this PR so it can be merged? If it is too much trouble for you, we will try to do our best to use the most of your contributions that we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request added an dialog which appears when the user clicks "Extract" in the context menu.
In this dialog the user can choose a name for the new extracted folder. It also supports paths as input parameter in the new dialog.
This PR also supports extraction when s3 is set as primary storage.
Resolved #64, Resolved #54 Resolved #43