Repository navigation
🫥 fix: Hide the Web Search Source Rails Scrollbar - #17359
Merged
Merged
Conversation
The three horizontal rails carried a class Tailwind 3 never generated, so they still draw a scrollbar. They now use the app's hide-scrollbar helper; the links inside stay focusable, so the rails stay reachable by keyboard and touch.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web search source rails in
Web/Sources.tsx(the two source grids) carriedscrollbar-none, which Tailwind 3 never generated, so they still draw a horizontal scrollbar. They now use the app'shide-scrollbarhelper, asCategoryTabsandUIResourceCarouseldo. The rails hold links, so their content stays reachable by keyboard focus and touch scrolling. The tab panel needs no class of its own, because the grids it holds already hide their scrollbars; leaving it alone keeps the recordedshadcn/no-restylecount unchanged.Related: berry-13#308
Type of change
Testing
Tested environments/configuration:
scrollbar-width: noneplus the WebKit rule) and is theme independent, so light and dark render the same.Automated tests:
eslint-suppressions.jsonis unchanged from dev.Screenshots / recordings
No user-facing change beyond the removed scrollbar.
Risk / compatibility
Low. Scrollable rails without a scrollbar rely on focusable links and touch; no pointer-only affordance is removed.
Checklist