-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 02-importing-data.md #208 and #289 #292
Conversation
Added instructor note to "Create New" step 9 Added instructor note to "Going Further"
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-292 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-07-01 17:07:25 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be a blank line before the ::::: instructor
markup otherwise it isn't correctly detected
I can't find any particular guidance on this but I'd suggest we keep the length of the various block markup consistent through the document
removed ../ before internal link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ostephens I'm getting a bit turned around and will review tomorrow morning.
Thanks! Co-authored-by: Zhian N. Kamvar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Zhian's spaces (tab?) to maintain list structure
Unified length of fenced div colons for both instructor notes.
Added Zhian's revision for internal link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is addressed in other commit thread?
Thanks @jas58 - this all looks good to me! |
Auto-generated via {sandpaper} Source : aa14705 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-07-03 11:35:31 +0000 Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1 Update 02-importing-data.md #208 and #289
Auto-generated via {sandpaper} Source : 535dbd1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-03 11:36:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : aa14705 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-07-03 11:35:31 +0000 Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1 Update 02-importing-data.md #208 and #289
Auto-generated via {sandpaper} Source : 535dbd1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-03 11:36:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : aa14705 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-07-03 11:35:31 +0000 Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1 Update 02-importing-data.md #208 and #289
Auto-generated via {sandpaper} Source : 535dbd1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-03 11:36:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : aa14705 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-07-03 11:35:31 +0000 Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1 Update 02-importing-data.md #208 and #289
Auto-generated via {sandpaper} Source : 535dbd1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-03 11:36:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : aa14705 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-07-03 11:35:31 +0000 Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1 Update 02-importing-data.md #208 and #289
Auto-generated via {sandpaper} Source : 535dbd1 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-07-03 11:36:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : aa14705 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-07-03 11:35:31 +0000 Message : Merge pull request #292 from LibraryCarpentry/jas58-patch-1 Update 02-importing-data.md #208 and #289
Added instructor note to "Create New" step 9
Added instructor note to "Going Further"
based on info in Issues #208 and #289