Docker #26
Closed
Docker #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo.lock is tracked so we need to allow usage of the same crates in container builds.
There was a lot of redundancy between the Dockerfile and the rust-toolchain.toml file. It turns out that rust-toolchain.toml does almost all the needed configuration needed for a container build so the Dockerfile can be reduced to 4 lines.
|
I just pushed a new version to the repository. I think I did a few of the things you did, but I am not sure. Can I merge the request? |
|
you should be able to merge it. the feature flags patch should be redundant now. the rust-toolchain.toml file would create a conflict as I'm using the nightly-2023-07-11 version in my PR. I don't know why patch e49ec3a showed up here. i was experimenting with bootimage on my forked repo. |
|
Why did you close it? |
Some of the individual patches are still valid. the full patch set kept getting invalidated by your changes in the same files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Features of this PR were inspired by the work of xonmello and earney and replaces #22