Repository navigation
fix(pre_run): 补回 stacked PR 未进入 main 的后三段 - #31
Merged
Merged
Conversation
* 暂时杀全部适配的脚本/进程 * 支持关闭具有启动器的python脚本
* 优化杀进程性能 * add test
原先只看 exited（日志里有没有退出标记），但正常退出 ≠ 做完了：脚本完全可能 跑完流程正常收尾、却一项日常都没做成（ok-ef「部分失败」仍会写退出标记）， 这类会被漏掉不再重跑。 改为「没有确凿证据表明这次跑成功」：未正常退出 或 日常没做完 都进重跑名单。 配套让 parse_daily 在未配 daily_success_marker 时返回 True——否则无 marker 的 脚本恒为 False，会每次都进重跑名单。 今早实测：重跑名单由 ['ok-nte'] 变为 ['BetterGI','ok-ef','ok-nte']， 正好是日常没做完的三个。
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28/#29/#30 是 stacked PR，合入#24而未合入main
修复
从
main建分支，并cherry-pick：d09c27f第 2 段（feat(pre_run): close_running 端到端 + pre_run 收敛为单一 builder #28）close_running 端到端 + pre_run 收敛为单一 builderf6ae2ae第 3 段（feat(pre_run): 关全量脚本 + 认出启动器真身（cmdline 匹配） #29）关全量脚本 + 认出启动器真身（cmdline 匹配）b829fde第 4 段（perf(pre_run): 关闭残留进程一次扫描，17.3s → 2.2s #30）关闭残留进程一次扫描，17.3s → 2.2s附带：重跑判据改为基于日常是否做完
原先看
exited（日志里有没有正常退出标记）发现这不利于ai基于日志迭代，改为判断日常是否完成
后续将清理判断跑完的逻辑
验证
全量 734 passed / 1 skipped / 11 subtests；ruff check + format