Repository navigation
fix: 修复 Rust 更新取消闪烁并推荐 Rust 发布包 - #153
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe update dialog now queues cancellation for active operations and sends it through polling when a job ID is available. Release notes now recommend the Rust package, name a backup package, and instruct users to extract the package. ChangesUpdate dialog cancellation
Release package instructions
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Cancelling an update check or download is now queued and sent once the job is known, and the dialog closes when the job ends. The release notes now recommend the Rust package. No concrete defects remain, so the risk to merging is minimal. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
更新检查或下载期间,后台每 400ms 轮询任务状态,取消按钮随请求 busy 状态反复禁用和启用,导致闪烁且可能漏掉点击。
取消按钮及关闭入口现在在更新任务期间保持可用。点击后记录取消意图,等当前请求返回、任务 ID 可用时发送一次取消请求,再继续轮询直到任务结束后关闭窗口;安装交接仍禁止取消。
验证:
发布说明:自动发布模板将 OneDragon-Helper-Rust.zip 标为推荐包,OneDragon-Helper.zip 标为备用包;已同步更新 v1.0.3 Release 页面。工作流 YAML 解析及 git diff --check 通过。
Summary by CodeRabbit
OneDragon-Helper-Rust.zip, listOneDragon-Helper.zipas a backup option, and clarify that the downloaded package should be extracted.