Feature/#144 add download button #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliodiez
reviewed
Mar 7, 2022
| element.href = URL.createObjectURL(file); | ||
| element.download = `Codepaster_Session_${dateNow}.txt`; | ||
| element.click(); | ||
| }; |
There was a problem hiding this comment.
This is not using prettier formatting, @manudous will guide you setting up this
brauliodiez
reviewed
Mar 7, 2022
front/src/common/log-download.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| export const handleDownSessionContent = (sessionContent: string) => { | |||
There was a problem hiding this comment.
rather
handleDownloadSessionContent
brauliodiez
reviewed
Mar 7, 2022
brauliodiez
reviewed
Mar 7, 2022
|
|
||
| max-width:50%; | ||
|
|
||
| } |
There was a problem hiding this comment.
Could this be simplified since we are using material ui?
There was a problem hiding this comment.
added spacing method instead of "50%"
brauliodiez
reviewed
Mar 7, 2022
| @@ -118,3 +118,45 @@ export const undoIcon = css` | |||
| display: initial; | |||
| } | |||
| `; | |||
|
|
|||
| export const downButton = css` | |||
There was a problem hiding this comment.
renamed to downloadButton and downloadIcon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added download button functionality.
added date when it generates the txt file.
edited css file.