LemonOS - Corrections. #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the comments, I added the problems and possible solutions for the code. I didn't write the complete code for that because I don't really know where everything is located. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, four files were "fixed" by removing unnecessary things from them. Likewise, the explanation of "why this is done" and "how to fix it" is within the same files.
What was fixed were unnecessary and silly things (so to speak). Honestly, I hope they continue to improve the project; it's a very good project with a bright future!
Suggestion:
I recommend using Makefiles to build the OS, as it's more convenient and practical. It's especially useful if you want to add a command that installs everything and builds modules :)
FILES CORRECTED:
LemonOS/Kernel/src/TTY/PTY.cpp
LemonOS/Kernel/src/Logging.cpp
LemonOS/Kernel/src/Math.cpp
LemonOS/Kernel/src/Fs/VolumeManager.cpp
Happy day/afternoon/night! - NopAngel