fix(release): let a fork publish and consume its own images - #129
Open
sergiomaldo wants to merge 1 commit into
Open
fix(release): let a fork publish and consume its own images#129sergiomaldo wants to merge 1 commit into
sergiomaldo wants to merge 1 commit into
Conversation
Two hard-coded references to `legalquants` make a fork of this repo
unable to build or run itself, which matters most in exactly the
situation forks exist for: carrying a patch while it is in review here.
`release.yml` pinned `NAMESPACE: legalquants`. A fork's workflow run
authenticates as the fork owner, then tries to push to a namespace it
has no write access to, and fails at the first push. The workaround is
to edit the workflow, which then shows up as a diff in every PR that
fork sends back. `github.repository_owner` resolves to `legalquants`
here, so upstream behaviour is unchanged.
`docker-compose.release.yml` hard-coded the pull namespace, so someone
following the documented install against a fork silently got upstream's
images — the stack comes up healthy and runs code the operator did not
intend, which is worse than failing. It is now
`${DONNA_IMAGE_NAMESPACE:-legalquants}`, documented in `.env.example`,
with the same default.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hard-coded references to
legalquantsmake a fork of this repounable to build or run itself, which matters most in exactly the
situation forks exist for: carrying a patch while it is in review here.
release.ymlpinnedNAMESPACE: legalquants. A fork's workflow runauthenticates as the fork owner, then tries to push to a namespace it
has no write access to, and fails at the first push. The workaround is
to edit the workflow, which then shows up as a diff in every PR that
fork sends back.
github.repository_ownerresolves tolegalquantshere, so upstream behaviour is unchanged.
docker-compose.release.ymlhard-coded the pull namespace, so someonefollowing the documented install against a fork silently got upstream's
images — the stack comes up healthy and runs code the operator did not
intend, which is worse than failing. It is now
${DONNA_IMAGE_NAMESPACE:-legalquants}, documented in.env.example,with the same default.
Verified both directions resolve:
🤖 Generated with Claude Code