#42 feat: 출석일정 admin 도메인 구현 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…성한 날짜 기준으로 캘린더에 표시됨
Closed
huncozyboy
reviewed
Jul 22, 2024
|
|
||
| public class AttendanceEventTypeNotMatchException extends TypeNotMatchException{ | ||
| public AttendanceEventTypeNotMatchException() {super("출석일정은 직접 수정할 수 없습니다.");} | ||
| } |
There was a problem hiding this comment.
출석일정 직접 수정이 불가능하도록 상세하게 예외처리를 해준 부분이 좋습니다 !
Comment on lines
+65
to
+68
| return events.stream() | ||
| .map(noticeMapper::toNoticeDto) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
스트림의 사용을 통한 DTO 반환이 흥미로웠습니다 .toList();를 사용하여 리스트 형태로 반환하는거까지 가독성이 좋다고 생각했습니다 저도 DTO 반환시 참고하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 개발내용
2. 구현 세부사항
3. 메모