Skip to content

feat: component admin setWithdrawalFeesInEth#132

Open
Torof wants to merge 5 commits intoLedgityLabs:mainfrom
Torof:admin-set-withdraw-fee-in-eth
Open

feat: component admin setWithdrawalFeesInEth#132
Torof wants to merge 5 commits intoLedgityLabs:mainfrom
Torof:admin-set-withdraw-fee-in-eth

Conversation

@Torof
Copy link

@Torof Torof commented Jul 1, 2024

added component in admin panel to setWithdrwalFeeInEth

@vercel
Copy link

vercel bot commented Jul 1, 2024

@Torof is attempting to deploy a commit to the Ledgity Team on Vercel.

A member of the Team first needs to authorize it.

@Torof Torof changed the title admin fees in Eth cp feat: component admin setWithdrawalFeesInEth Jul 2, 2024
Copy link
Contributor

@magbeans magbeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@Torof If possible, can you also remove those files?
Contract folder(ie. setWithdrawalFeeInEth) is already modified on myside.

"d3-format": "^3.1.0",
"dayjs": "^1.11.11",
"embla-carousel-react": "^8.0.2",
"ethers": "^5.7.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Torof Can you remove this library? we currently use viem instead of ethers.

@magbeans
Copy link
Contributor

@Torof You need to revert package-lock.json file changes.
And also resolve conflicts by rebasing current PR.

@Torof Torof requested a review from magbeans July 22, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants