Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LIVE-16993 updated swap error messages #9223

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Feb 13, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Screenshot 2025-02-13 at 15 51 27 Screenshot 2025-02-13 at 16 01 30

❓ Context

[JIRA-16993]

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner February 13, 2025 15:25
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 13, 2025 3:25pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Feb 13, 2025 3:25pm
native-ui-storybook ⬜️ Ignored (Inspect) Feb 13, 2025 3:25pm
react-ui-storybook ⬜️ Ignored (Inspect) Feb 13, 2025 3:25pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant