Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aptos derivation path parsing method #9218

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

semeano
Copy link
Contributor

@semeano semeano commented Feb 13, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fixes issue when parsing derivation path. This is required for swap to work properly.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 13, 2025 5:39pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:39pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:39pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:39pm

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Feb 13, 2025
@semeano semeano changed the title fix: aptos exchange fix: aptos derivation path parsing method Feb 13, 2025
@semeano semeano marked this pull request as ready for review February 13, 2025 15:27
@semeano semeano requested a review from a team as a code owner February 13, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant