Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coin-modules on affected files #9203

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Feb 12, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner February 12, 2025 13:58
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 3:05pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 3:05pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 3:05pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 3:05pm

@Wozacosta
Copy link
Contributor

Quick question about this file
image

.github/workflows/test-integration-pr.yml
Do we want it to be triggered also when coin-modules are changed?

@Canestin
Copy link
Contributor Author

Quick question about this file image

.github/workflows/test-integration-pr.yml Do we want it to be triggered also when coin-modules are changed?

Hi @Wozacosta, It is exactly what we expected.

Wozacosta
Wozacosta previously approved these changes Feb 13, 2025
@Canestin Canestin enabled auto-merge February 13, 2025 10:34
@Canestin Canestin force-pushed the LIVE-16982-fix-ci-bridge-tests branch from d50a790 to ebf4b91 Compare February 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants